Wireshark-commits: [Wireshark-commits] master 5844761: fix a crash in the endpoint dialogue

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 8 Nov 2014 14:19:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=58447619b632460a24944f57d1eb22fd9aa9fffd
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5844761 by Martin Kaiser (wireshark@xxxxxxxxx):

    fix a crash in the endpoint dialogue
    
    compile Wireshark with GeoIP enabled
    load a USB capture
    open Statistics / Endpoints
       the tree is empty, USB is not amongst the selected Enpoint Types
    select USB in the Endpoint Types list
    -> crash
    
    to fix this, add a NULL check for cur_tree to EndpointDialog::tabChanged()
    
    Change-Id: I43d963ae5cd451120ac354e89e37ccbbbc2c5910
    Reviewed-on: https://code.wireshark.org/review/5192
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  47909d3   remove parent parameter from dissect_usb_setup_response()
    adds  5844761   fix a crash in the endpoint dialogue


Summary of changes:
 ui/qt/endpoint_dialog.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)