On Jul 20, 2024, at 3:09 AM, John Thacker <johnthacker@xxxxxxxxx> wrote:
> On Fri, Jul 19, 2024, 10:53 PM Guy Harris <gharris@xxxxxxxxx> wrote:
>
>> On Jul 19, 2024, at 5:39 PM, John Thacker <johnthacker@xxxxxxxxx> wrote:
>>
>>> On Fri, Jul 19, 2024 at 8:07 PM Guy Harris <gharris@xxxxxxxxx> wrote:
>>>
>>> Not sure what it's diffing there, given that both epan/dissectors/asn1/pkcs12/packet-pkcs12-template.c and epan/dissectors/packet-pkcs12.c appear to be passing TRUE to g_string_free() in the one and only call to g_string_free().
>>
>> It's diffing that the MR in question is changing that TRUE to true, but not changing the template in the asn1 directory.
>
> Which MR is that?
>
> https://gitlab.com/wireshark/wireshark/-/merge_requests/16485
And that's change 75ea337b681d6a21f5d9b896005057cd4139a919, which doesn't modify the PKCS12 dissector; it was done after the generated ASN.1 were changed, so it didn't have to - and changed no packet-XXX-template.c files for ASN.1 dissectors.
It *did* change one TRUE to true in a g_string_free() call, but that was in epan/dissectors/packet-protobuf.c.