On Jul 19, 2024, at 5:39 PM, John Thacker <johnthacker@xxxxxxxxx> wrote:
> On Fri, Jul 19, 2024 at 8:07 PM Guy Harris <gharris@xxxxxxxxx> wrote:
>
>> Not sure what it's diffing there, given that both epan/dissectors/asn1/pkcs12/packet-pkcs12-template.c and epan/dissectors/packet-pkcs12.c appear to be passing TRUE to g_string_free() in the one and only call to g_string_free().
>
> It's diffing that the MR in question is changing that TRUE to true, but not changing the template in the asn1 directory.
Which MR is that?
The pipeline that Anders shared that was failing was for the MR above. The cppcheck script sometimes seems to print some spurious errors when files are changed that contain macros because it only checks the changed files in a MR, or something like that. At least that doesn't cause a failure.