Wireshark-dev: Re: [Wireshark-dev] Failed piplines unrelated WS_DEPRECATED_X ?

From: Gerald Combs <gerald@xxxxxxxxxxxxx>
Date: Fri, 19 Jul 2024 14:19:56 -0700
The cppcheck warning needs to be fixed, but it looks like the job is failing due to a change in packet-pkcs12.c:

----
diff --git a/epan/dissectors/packet-pkcs12.c b/epan/dissectors/packet-pkcs12.c
index 3412292d..65796bf9 100644
--- a/epan/dissectors/packet-pkcs12.c
+++ b/epan/dissectors/packet-pkcs12.c
@@ -423,7 +423,7 @@ int PBE_decrypt_data(const char *object_identifier_id_param _U_, tvbuff_t *encry
 	/* add it as a new source */
 	add_new_data_source(actx->pinfo, clear_tvb, name->str);
- g_string_free(name, true);
+	g_string_free(name, TRUE);
/* now try and decode it */
 	call_ber_oid_callback(object_identifier_id_param, clear_tvb, 0, actx->pinfo, tree, NULL);
----

(You have to expand the "Regenerating ASN.1 dissectors" section)

On 7/19/24 2:06 PM, Anders Broman wrote:
Hi,
Not sure why this pipeline fails. Can someone help?

https://gitlab.com/wireshark/wireshark/-/jobs/7386780020 <https://gitlab.com/wireshark/wireshark/-/jobs/7386780020>

./tools/cppcheck/cppcheck.sh -l $NUM_COMMITS | tee cppcheck/cppcheck_report.txt [0;m

epan/tvbuff.h:1083:1: warning: There is an unknown macro here somewhere. Configuration is required. If WS_DEPRECATED_X is a macro then please configure it. [unknownMacro]


Best regards

Anders


___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe