Wireshark-dev: Re: [Wireshark-dev] Failed piplines unrelated WS_DEPRECATED_X ?

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxx>
Date: Fri, 19 Jul 2024 19:53:28 -0700
On Jul 19, 2024, at 5:39 PM, John Thacker <johnthacker@xxxxxxxxx> wrote:

> On Fri, Jul 19, 2024 at 8:07 PM Guy Harris <gharris@xxxxxxxxx> wrote:
> 
>> Not sure what it's diffing there, given that both epan/dissectors/asn1/pkcs12/packet-pkcs12-template.c and epan/dissectors/packet-pkcs12.c appear to be passing TRUE to g_string_free() in the one and only call to g_string_free().
> 
> It's diffing that the MR in question is changing that TRUE to true, but not changing the template in the asn1 directory.

Which MR is that?  It *shouldn't* be changed to true, as the formal argument is a gboolean, not a bool, and, at least in the tip of the master branch, it *isn't* changed to true.  That's not generated code, so it shouldn't be affected by any change to asn2wrs.

And I'm not seeing any commits to epan/dissectors/packet-pkcs12.c on the main branch in which true, rather than TRUE, was passed to g_string_free().