[bugzilla-daemon@xxxxxxxxxxxxx]

Bug ID	8581
Summary	More intuitive and less ambiguous variable names and labels
Classification	Unclassified
Product	Wireshark
Version	1.9.x (Experimental)
Hardware	x86
OS	Windows 7
Status	UNCONFIRMED
Severity	Minor
Priority	Low
Component	Wireshark
Assignee	bugzilla-admin@wireshark.org
Reporter	turney_cal@emc.com

Build Information:

--
NFS variable names and labels should be more inituitive and less ambiguous;
version-specific routines should be identified as such; and general readability
changes are needed for users and developers. The patch includes the following:  

* Filter name "rpc.array.len", the number of ACEs returned in the response,
  changed  to "nfs.num_aces"
* "hf_nfs_cookieverf4" was changed to "hf_nfs_cookie_verf4"
* "ett_nfs4_fattr4..." names were changed to "ett_nfs_fattr4..." in conformance
  with the naming convention of that list
* A space was added after the colon in <name:value> strings in the Info column
  (e.g., "FH:0x%08x" to "FH: 0x%08x" and "Error:%s" to "Error: %s").
* "bitmap_len" which sounds like it might be the size of one or more bitmaps
  is actually the number of bitmaps. It was renamed "num_bitmaps".
  Similarly, "MAX_BITMAP_LEN" was changed to "MAX_BITMAPS".
* Lines wider than 102 bytes were divided.
* 'dissect_ftype()' was changed to 'dissect_nfs_ftype2'
* 'dissect_fattr()' was changed to 'dissect_nfs_fattr2'
* 'dissect_stat()' was changed to 'dissect_nfs_status2'
* 'dissect_nfs_nfsstat4" to ''dissect_nfs_status4' 
* Uninitialized *proto_tree; and *proto_item; variables were initialized to
  NULL.

---

      You are receiving this mail because:

• You are watching all bug changes.