Wireshark-bugs: [Wireshark-bugs] [Bug 8581] More intuitive and less ambiguous variable names and

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 14 Apr 2013 23:31:57 +0000

Comment # 4 on bug 8581 from 
(In reply to comment #3)
> Generally +1 to the changes, also agree with the proposed naming change of
> *_nfs_*4 -> *_nfs4_*

Initializing the *proto_tree and *proto_item variables
> to NULL is unnecessary though. The compiler (GCC, at least) is smart enough
> to know when a variable might be used before being set, so adding extra
> initializers just makes more work for the optimizer.

Cheers,
Evan

Hi Evan, 
I agree but I'm going to be submitting 3 more patches.  One of them involves
checking if 'tree' is non-NULL in order to reduce load time by 20%. Perhaps I
should have moved the initialization changes to that patch. You can either
remove them for now or trust that I will soon be submitting a patch that
requires them. =) 

Fun times,
Cal

You are receiving this mail because:
  • You are watching all bug changes.