Hello Guy,
On 2024-02-13 01:28, Guy Harris wrote:
On Feb 12, 2024, at 1:15 PM, Oliver Hartkopp <socketcan@xxxxxxxxxxxx> wrote:
Excellent! That seems to be the right approach.
OK, so:
fix libpcap to put the priority/VCID field in big-endian order in CAN XL frames:
https://github.com/the-tcpdump-group/libpcap/commit/eb6cfd8feae85b67529bb3c82f6a97bfd98c73f3 in the main branch
https://github.com/the-tcpdump-group/libpcap/commit/23904ebe85c4556b77578fd8d61ef82d9bab62b4 in the 1.10 branch
change Wireshark to treat that field as big-endian:
https://gitlab.com/wireshark/wireshark/-/commit/38a29e82cc96f727aeab7f10e751fa6e8d5e45b6 in the main branch
https://gitlab.com/wireshark/wireshark/-/commit/b763663904b6101764c414056b9248803569d6d2 in the 4.2 branch
update the LINKTYPE_CAN_SOCKETCAN spec to reflect all that:
https://github.com/the-tcpdump-group/tcpdump-htdocs/commit/9c357d9ed6d214bd2fc44850138c2f8861782d88
and it'll show up on the site within 24 hours.
I can confirm that all type of CAN frames (CAN CC/FD/XL) are now
displayed correctly with the latest Wireshark
v4.3.0rc0-1528-g37937ef51444. As expected I just don't see the CAN FD
flags due to my current (outdated) Debian libpcap 1.10.4.
Great job!!
Many thanks and best regards,
Oliver