Wireshark-dev: Re: [Wireshark-dev] Valgrind profiling results gone bad

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Anders Broman <anders.broman@xxxxxxxxxxxx>
Date: Fri, 12 Sep 2014 11:55:17 +0000

I reopened https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10329

Regards

Anders

 

From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Anders Broman
Sent: den 11 september 2014 16:30
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] Valgrind profiling results gone bad

 

 

 

 

>The culprit seems to be proto_tre_add_item() does any one know what changed? and why?

 

Hi,

Looking further into it I think the regression is introduced in  

commit

5460d7fa0cd13f84ff567c96ee89d07b37cd4b62

https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5460d7fa0cd13f84ff567c96ee89d07b37cd4b62

 

I suspect (PTREE_FINFO(tree)->ds_tvb

May be NULL if the previous item was faked.

 

Regards

Anders