Wireshark-dev: Re: [Wireshark-dev] Valgrind profiling results gone bad ( part1)

From: Anders Broman <anders.broman@xxxxxxxxxxxx>
Date: Thu, 11 Sep 2014 08:54:18 +0000

 

 

From: Anders Broman
Sent: den 11 september 2014 10:36
To: wireshark-dev@xxxxxxxxxxxxx
Subject: Valgrind profiling results gone bad

 

Hi,

I just re-ran my ”standard file” for profiling and the results differs significantly:

tools/valgrind-wireshark.sh -p -Y -b /home/ericsson/wireshark/ /home/ericsson/etxrab/TCT_SIP_traffic.pcapng

==13803== Callgrind, a call-graph generating cache profiler

==13803== Copyright (C) 2002-2013, and GNU GPL'd, by Josef Weidendorfer et al.

==13803== Using Valgrind-3.10.0.SVN and LibVEX; rerun with -h for copyright info

==13803== Command: /home/ericsson/wireshark/.libs/lt-tshark -Y frame -nr /home/ericsson/etxrab/TCT_SIP_traffic.pcapng

==13803==

==13803== For interactive control, run 'callgrind_control -h'.

==13803==

==13803== Events    : Ir

==13803== Collected : 18090231417

==13803==

==13803== I   refs:      18,090,231,417

 

2014-09-11 Wireshark 1.99.0 (v1.99.0-rc1-1731-g29993d5 from master

tools/valgrind-wireshark.sh -p -Y -b /home/ericsson/wireshark/ /home/ericsson/etxrab/TCT_SIP_traffic.pcapng

==27929== Callgrind, a call-graph generating cache profiler

==27929== Copyright (C) 2002-2013, and GNU GPL'd, by Josef Weidendorfer et al.

==27929== Using Valgrind-3.10.0.SVN and LibVEX; rerun with -h for copyright info

==27929== Command: /home/ericsson/wireshark/.libs/lt-tshark -Y frame -nr /home/ericsson/etxrab/TCT_SIP_traffic.pcapng

==27929==

==27929== For interactive control, run 'callgrind_control -h'.

==27929==

==27929== Events    : Ir

==27929== Collected : 28056629440

==27929==

==27929== I   refs:      28,056,629,440

 

The culprit seems to be proto_tre_add_item() does any one know what changed? and why?

 

 

Attachment: callgrind.out.27929.bz2
Description: callgrind.out.27929.bz2