Wireshark-dev: Re: [Wireshark-dev] Valgrind profiling results gone bad

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Anders Broman <anders.broman@xxxxxxxxxxxx>
Date: Thu, 11 Sep 2014 14:29:58 +0000

 

 

 

>The culprit seems to be proto_tre_add_item() does any one know what changed? and why?

 

Hi,

Looking further into it I think the regression is introduced in  

commit

5460d7fa0cd13f84ff567c96ee89d07b37cd4b62

https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5460d7fa0cd13f84ff567c96ee89d07b37cd4b62

 

I suspect (PTREE_FINFO(tree)->ds_tvb

May be NULL if the previous item was faked.

 

Regards

Anders