Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 44480: /trunk/ui/gtk/ /trunk/ui/gtk/

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Tue, 14 Aug 2012 13:30:01 +0200
On Tue, Aug 14, 2012 at 12:21:55AM +0000, gerald@xxxxxxxxxxxxx wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=44480
> 
> User: gerald
> Date: 2012/08/13 05:21 PM
> 
> Log:
>  Comment out -DGDK_DISABLE_DEPRECATED to match configure.in.
> 
> Directory: /trunk/ui/gtk/
>   Changes    Path              Action
>   +1 -1      CMakeLists.txt    Modified

I really think the patch should be the other way round - it should be enabled
in configure.in as well. Otherwise this option is just a waste of storage and
should be removed completely.

Ciao
  Jörg

-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.