Wireshark-commits: [Wireshark-commits] master-2.6 f15bf6a: Don't return TRUE with *err or *err_info

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 02 Oct 2018 11:06:40 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f15bf6afb81717332cc372659f61a8835754b21b
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

f15bf6a by Guy Harris (guy@xxxxxxxxxxxx):

    Don't return TRUE with *err or *err_info set.
    
    Read and seek-read routines shouldn't do that; it causes TShark to
    report an error when there was no error.
    
    Change-Id: If564348fa01dce83c6a2317ac56ac8716d514bf7
    Reviewed-on: https://code.wireshark.org/review/29972
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit c8bf7f47cd51ee49e8d53877b3900f5cff200d11)
    Reviewed-on: https://code.wireshark.org/review/29973
    

Actions performed:

    from  384e06d   TLS: fix reassembly regression when extending a PDU
     add  f15bf6a   Don't return TRUE with *err or *err_info set.


Summary of changes:
 wiretap/ascendtext.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)