Wireshark-commits: [Wireshark-commits] master-2.4 647cc58: Don't return TRUE with *err or *err_info

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 02 Oct 2018 11:06:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=647cc58b1dea57be803439f97cbe54bce1f5667e
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

647cc58 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't return TRUE with *err or *err_info set.
    
    Read and seek-read routines shouldn't do that; it causes TShark to
    report an error when there was no error.
    
    Change-Id: If564348fa01dce83c6a2317ac56ac8716d514bf7
    Reviewed-on: https://code.wireshark.org/review/29972
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 5df87a5ad7b9f90519633c2ba793e57dce6ad212)
    Reviewed-on: https://code.wireshark.org/review/29974
    

Actions performed:

    from  8dee55d   TLS: fix reassembly regression when extending a PDU
     add  647cc58   Don't return TRUE with *err or *err_info set.


Summary of changes:
 wiretap/ascendtext.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)