Wireshark-commits: [Wireshark-commits] master 5df87a5: Don't return TRUE with *err or *err_info set

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 02 Oct 2018 11:06:33 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5df87a5ad7b9f90519633c2ba793e57dce6ad212
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5df87a5 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't return TRUE with *err or *err_info set.
    
    Read and seek-read routines shouldn't do that; it causes TShark to
    report an error when there was no error.
    
    Change-Id: If564348fa01dce83c6a2317ac56ac8716d514bf7
    Reviewed-on: https://code.wireshark.org/review/29972
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  2263ce4   TLS: fix reassembly regression when extending a PDU
     add  5df87a5   Don't return TRUE with *err or *err_info set.


Summary of changes:
 wiretap/ascendtext.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)