Wireshark-commits: [Wireshark-commits] master-2.6 0bc642e: Extcap programs must write to the packet

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 19 Jul 2018 09:33:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0bc642e7773865e96ef0c9c62177afa7cc30b29f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

0bc642e by Guy Harris (guy@xxxxxxxxxxxx):

    Extcap programs must write to the packet pipe in binary mode.
    
    It doesn't matter on UN*X, but it definitely matters on Windows; we're
    writing a pcap file, not a text file, so every byte we write should go
    down the pipe as is.
    
    Bug: 14989
    Change-Id: I26c067b8ff5dba644a579846dd97b568a81c7053
    Reviewed-on: https://code.wireshark.org/review/28764
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 065a76257935e0699b6cf4aa2352d2f7de914a87)
    Reviewed-on: https://code.wireshark.org/review/28765
    

Actions performed:

    from  fd1d379   2.6.2 → 2.6.3.
    adds  0bc642e   Extcap programs must write to the packet pipe in binary mode.


Summary of changes:
 extcap/ciscodump.c | 2 +-
 extcap/udpdump.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)