Wireshark-commits: [Wireshark-commits] master 065a762: Extcap programs must write to the packet pip

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 19 Jul 2018 09:31:06 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=065a76257935e0699b6cf4aa2352d2f7de914a87
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

065a762 by Guy Harris (guy@xxxxxxxxxxxx):

    Extcap programs must write to the packet pipe in binary mode.
    
    It doesn't matter on UN*X, but it definitely matters on Windows; we're
    writing a pcap file, not a text file, so every byte we write should go
    down the pipe as is.
    
    Bug: 14989
    Change-Id: I26c067b8ff5dba644a579846dd97b568a81c7053
    Reviewed-on: https://code.wireshark.org/review/28764
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  268883d   WSUG: Update docs for 'Export Object'
    adds  065a762   Extcap programs must write to the packet pipe in binary mode.


Summary of changes:
 extcap/ciscodump.c | 2 +-
 extcap/dpauxmon.c  | 2 +-
 extcap/udpdump.c   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)