Wireshark-commits: [Wireshark-commits] master-2.4 57dc9e5: Extcap programs must write to the packet

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 19 Jul 2018 09:35:40 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=57dc9e59d9b1a41167ceccbbec616c0837541736
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

57dc9e5 by Guy Harris (guy@xxxxxxxxxxxx):

    Extcap programs must write to the packet pipe in binary mode.
    
    It doesn't matter on UN*X, but it definitely matters on Windows; we're
    writing a pcap file, not a text file, so every byte we write should go
    down the pipe as is.
    
    Bug: 14989
    Change-Id: I26c067b8ff5dba644a579846dd97b568a81c7053
    Reviewed-on: https://code.wireshark.org/review/28764
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 065a76257935e0699b6cf4aa2352d2f7de914a87)
    Reviewed-on: https://code.wireshark.org/review/28766
    

Actions performed:

    from  68faae0   2.4.8 → 2.4.9.
    adds  57dc9e5   Extcap programs must write to the packet pipe in binary mode.


Summary of changes:
 extcap/ciscodump.c | 2 +-
 extcap/udpdump.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)