Wireshark-commits: [Wireshark-commits] master-2.4 e3924a6: BSSMAP: Fix definition of Speech Version

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 07 Apr 2018 20:26:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e3924a6d6a3d97d6d5e204386c151e15505bb302
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

e3924a6 by Harald Welte (laforge@xxxxxxxxxxxx):

    BSSMAP: Fix definition of Speech Version Indication for EFR (FR2)
    
    3GPP TS 48.008 Section 3.2.2.11 is quite clear on the definitions
    of the "permitted speech version indication".
    
    The Wireshark BSSMAP dissector so far got it wrong:
    * 0x11 is "Full Rate Version 2" (aka GSM-EFR)
    * the short version is not FR12 but FR2
    
    Change-Id: I6835083389e465c791cea5a240ebc434f677b82c
    Reviewed-on: https://code.wireshark.org/review/26790
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit 5b0c6f9e058bb07df970956f01f0e15d1ed15af6)
    Reviewed-on: https://code.wireshark.org/review/26792
    

Actions performed:

    from  ddda23e   extcap: Always use byte mode in pipes
    adds  e3924a6   BSSMAP: Fix definition of Speech Version Indication for EFR (FR2)


Summary of changes:
 epan/dissectors/packet-gsm_a_bssmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)