Wireshark-commits: [Wireshark-commits] master-2.2 9b01353: BSSMAP: Fix definition of Speech Version

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 07 Apr 2018 20:27:18 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9b013536c1bf3d6e822da215612f64cca1a13b13
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

9b01353 by Harald Welte (laforge@xxxxxxxxxxxx):

    BSSMAP: Fix definition of Speech Version Indication for EFR (FR2)
    
    3GPP TS 48.008 Section 3.2.2.11 is quite clear on the definitions
    of the "permitted speech version indication".
    
    The Wireshark BSSMAP dissector so far got it wrong:
    * 0x11 is "Full Rate Version 2" (aka GSM-EFR)
    * the short version is not FR12 but FR2
    
    Change-Id: I6835083389e465c791cea5a240ebc434f677b82c
    Reviewed-on: https://code.wireshark.org/review/26790
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit 5b0c6f9e058bb07df970956f01f0e15d1ed15af6)
    Reviewed-on: https://code.wireshark.org/review/26793
    

Actions performed:

    from  4b5c587   Don't install PortAudio if we're not installing GTK+.
    adds  9b01353   BSSMAP: Fix definition of Speech Version Indication for EFR (FR2)


Summary of changes:
 epan/dissectors/packet-gsm_a_bssmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)