Wireshark-commits: [Wireshark-commits] master-2.6 dc23633: BSSMAP: Fix definition of Speech Version

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 07 Apr 2018 20:26:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dc236333138c5d031f257fd5d3da5a66fcbc6b9c
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

dc23633 by Harald Welte (laforge@xxxxxxxxxxxx):

    BSSMAP: Fix definition of Speech Version Indication for EFR (FR2)
    
    3GPP TS 48.008 Section 3.2.2.11 is quite clear on the definitions
    of the "permitted speech version indication".
    
    The Wireshark BSSMAP dissector so far got it wrong:
    * 0x11 is "Full Rate Version 2" (aka GSM-EFR)
    * the short version is not FR12 but FR2
    
    Change-Id: I6835083389e465c791cea5a240ebc434f677b82c
    Reviewed-on: https://code.wireshark.org/review/26790
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit 5b0c6f9e058bb07df970956f01f0e15d1ed15af6)
    Reviewed-on: https://code.wireshark.org/review/26791
    

Actions performed:

    from  73a5b4d   extcap: Always use byte mode in pipes
    adds  dc23633   BSSMAP: Fix definition of Speech Version Indication for EFR (FR2)


Summary of changes:
 epan/dissectors/packet-gsm_a_bssmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)