Michael Mann
changed
bug 9631
| What |
Removed |
Added |
| Attachment #12448 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 3
on bug 9631
from Michael Mann
Comment on attachment 12448 [details]
SVN diff against trunk rev 54684
A few issues:
1. proto_tree_add_item now needs an encoding value (not FALSE).
\tools\fix-encoding-args.pl should help with the conversion.
2. filter names should be prefaced with dissector filter name (seems to be
"pathport"). "Pathport" also seems like a more appropriate short name.
3. checkhf.pl reports:
Unused entry: /cygdrive/c/wireshark/epan/dissectors/packet-pathport.c,
hf_pp_data_universe
Unused entry: /cygdrive/c/wireshark/epan/dissectors/packet-pathport.c,
hf_pp_tlv_pad
4. pp_pid_vals is large enough that it should use a value_string_ext
5. HEADER_... #defines don't appear to be used and should be removed.
6. packet_is_pathport is called in dissect_pathport_common(), yet its called in
all "parent" functions.
You are receiving this mail because:
- You are watching all bug changes.