Wireshark-bugs: [Wireshark-bugs] [Bug 9631] Add dissector for Pathport Protocol

Date: Mon, 13 Jan 2014 18:34:35 +0000

changed bug 9631

What Removed Added
Attachment #12448 is obsolete   1
Attachment #12468 Flags   review_for_checkin?

Comment # 4 on bug 9631 from
Created attachment 12468 [details]
Patch with issues corrected.

Corrected issues from Michael Mann :

1. proto_tree_add_item now needs an encoding value (not FALSE). 
\tools\fix-encoding-args.pl should help with the conversion.

All set to ENC_NA 

2. filter names should be prefaced with dissector filter name (seems to be
"pathport").  "Pathport" also seems like a more appropriate short name.

Changed filter names and short name.

3. checkhf.pl reports:
Unused entry: /cygdrive/c/wireshark/epan/dissectors/packet-pathport.c,
hf_pp_data_universe
Unused entry: /cygdrive/c/wireshark/epan/dissectors/packet-pathport.c,
hf_pp_tlv_pad

Removed unused.

4. pp_pid_vals is large enough that it should use a value_string_ext

Changed to  value_string_ext. changed accessors.

5. HEADER_... #defines don't appear to be used and should be removed.

Removed unused HEADER_ #defines and renamed remaining to PATHPORT_HEADER_xxx to
reduce name space pollution.

6. packet_is_pathport is called in dissect_pathport_common(), yet its called in
all "parent" functions.

Fixed.


You are receiving this mail because:
  • You are watching all bug changes.