Ethereal-dev: Re: [Ethereal-dev] Re: rev 17527: /trunk/plugins/profinet/: packet-pn-dcp.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Fri, 10 Mar 2006 22:42:11 +0100
Lars Roland wrote:
This patch is probably better.
It makes the while loop even more robust and if pdu boundaries are exceeded, an exception is thrown.
I've checked in a fix for this.

The length parameter seems to be no longer required (left over from debugging?) at the suboptions so I removed it. While looking at the code I've done some other (minor) code cleanup.

I've also added a check to the while loop to prevent an infinite loop and checked it all against some traces.

Anyway, thanks for having a look at the code. You may have a look at my changes in case I've added new bugs :-)

Regards, ULFL