Ethereal-dev: [Ethereal-dev] Re: Patch for packet-smb.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
Date: Sat, 12 Nov 2005 17:58:31 -0400
Good stuff.


Checked in.


Maybe you would be interested in starting buliding or adding some SMB
information to the wiki,    similar to the SMB2 documentation we
already have in the wiki



On 11/10/05, Laurent Constantin <infos@xxxxxx> wrote:
> Hello,
>
> I write a SMB/CIFS client/server. Ethereal helps me a lot, so it's
> my pleasure to contribute back by proposing small improvements
> to SMB dissector.
>
> A patch for packet-smb.c is attached:
>  - it improves timeout decoding
>  - it defines common NT transaction IOCTL functions
>  - it corrects decoding of resume key in search queries
>  - it defines a new function dissect_4_2_16_8_unsure() to replace
>    dissect_4_2_16_8(). I'm unsure if it is correct. As said in
>    comments, it works for me, but I find strange that nobody noticed
>    dissect_4_2_16_8() was wrong. So, it is between "#if 0".
>    Someone else should confirm dissect_4_2_16_8_unsure() works
>    before activating it.
>
> This patch is against Ethereal 0.10.13.
>
> I tried to honour Ethereal coding style, but don't hesitate to
> reformat/rewrite the code.
>
> I'll be unreachable till Tuesday November 15th, so unable to
> answer emails.
>
> Regards,
> Laurent Constantin
> http://www.laurentconstantin.com/ for network tools
> http://vigilance.aql.fr/ for vulnerabilities
>