Ethereal-dev: Re: [Ethereal-dev] Statistics menu items, 2nd proposal

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Mon, 23 Feb 2004 00:24:53 +0100
Olivier Biot wrote:

From: Ulf Lamping

| Hi List!
|
| Second proposal for the statistics menu:
|
| a) Renamed all appearances of (Watch Protocol) to (Statistics)
|
| b) Made two new toplevel menu items "Transport" and "Application"
| I very often heard about the distinction between the "generic"
transport
| layers and the application specifics layers.

Looks promising!

You opt for top-level menu items. I agree they are convenient (simple
to access). Another approach is to preserve the Analyze top-level menu
and create the submenus in it (would only require a minor patch to
gtk/menu.c)

We could do a lot of possible ways here, without much effort, as long as we keep the OSI layers partition :-)
Do you think that the toplevel menu isn't the right way?
As we don't have that many toplevel items, and I don't see many new coming in the future, I think it's pretty ok. But no problem if someone is really against this approach (it's only a proposal, as written).

.

BTW two C++ comments slipped into the code. Which of both
switch(layer) {} should be run?
Sometimes the hand is faster than the brain ;-)
Already checked in a fix for this.

Regards, ULFL