Lars Roland wrote:
Hello all,
I have modified the generation process of the nsis installer.
Now only one installer is generated. If you build both the GTK1 and
GTK2 version of ethereal, the installer will also contain both
versions. The user has to decide, which version she or he wants to
have installed. The size of this new installer is 14 MB when lzma
compression is used.
The mechanism is similar to the "typical" / "custom" install you see
before in other installers.
I didn't know how to use this with NSIS before, good to know :-)
I think the idea is good, the text for the two install variants might be:
+!ifdef GTK1_DIR & GTK2_DIR
+InstType "Ethereal (typical)"
+InstType "Ethereal with modern GTK2 user interface"
+!endif
So users might better get an idea what the GTK1 / GTK2 thing is all about.
If only one version of ethereal is built, you will get the standard
installer for it.
I also modified the makefile for the asn1 plugin to make it build with
GTK2. However this is still not perfect. If you built with both GTK1
and GTK2, only the GTK1 version of this dll will be built. I would
prefer to have the GTK dependency of this dll removed.
When I remember this correct, the asn1 plugin can only be compiled with
the GTK2 things, as some GTK2 specific functions are used. However, the
GTK parts are not compiled be default.
I agree with you, that the GTK parts don't belong here anyway (but in
the gtk dir), so this has to be cleaned up (by the implementor of this
plugin?).
Patches are attached.
Please check in, if you think this is a useful approach.
Someone on the list only wanted to have the GTK2 parts, as his customers
don't like the "old" GTK1 surface any longer. He can simply not define
the GTK1_DIR and will get what he wants.
I like that idea. What do the others think?
Regards, ULFL