Ethereal-dev: Re: [Ethereal-dev] Number of icons on the toolbar changes ...

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Mon, 09 Feb 2004 19:33:48 +0100
Richard Sharpe wrote:

On Mon, 9 Feb 2004, Ulf Lamping wrote:

It seems that the number of items on the tool bar changes. In particular, one of the floppy icons disappears when you open a capture file.

Why is this?
That shouldn't be the case, seems like a bug.

The idea is to have the icon change, if the file is unsaved it should show to usual "Save" button (a floppy icon).
If the file is saved, it show the "Save As" button (a floppy with a pencil).

So only one of the two should be visible, if you see both, this is a bug.

This should work similar to the icons for a new capture (you will see the new capture *or* the stop icon, depending on the current state).

Could you explain, what you did to get this?

Well, if I run up the latest CVS (fresh from this morning), I see both the save and the save-as icons, even before I have started capturing anything. However, they are both grayed out.

If I capture some stuff, I see it change to only one icon. The Save one, presumably.

If I save the capture, I see it change to the Save As icon.

My fault, sorry!

As I usually don't start Ethereal without opening a capture file, I just didn't initialized the toolbar correctly.

I've checked in a bugfix for this.

Regards, ULFL