Ethereal-dev: Re: [Ethereal-dev] Additional commands dissected in SCSI

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Dinesh G Dutt <ddutt@xxxxxxxxx>
Date: Mon, 27 Oct 2003 12:52:35 -0800
VC6++ didn't show these errors. Sorry.

Guy Harris writes:
 > 	packet-scsi.c:3145: warning: unused parameter `isreq'
 > 	packet-scsi.c: In function `dissect_scsi_senddiag()':
 > 	packet-scsi.c:3437: warning: unused parameter `iscdb'
 > 	packet-scsi.c: In function `dissect_scsi_writebuffer':
 > 	packet-scsi.c:3460: warning: unused parameter `iscdb'
 > 
 > Do the routines in question need to check the arguments in question?
No, they really don't. But I wanted to keep all the dissection routines have
the same set of parameters so that I could replace the long list of "case"
statements with a jump table later on as Ronnie Sahlberg suggested when I first
submitted the code. 

Dinesh
-- 
I am not young enough to know everything. - Oscar Wilde