[Guy Harris <guy@xxxxxxxxxxxx>]

On Oct 25, 2003, at 9:39 PM, Dinesh G Dutt wrote:

> This patch adds dissection code for the following additional SCSI 
> commands:
>      - Start/Stop Unit
>      - Write Buffer
>      - Send Diagnostics
>
> It also contains a cleaned up patch for displaying the serial number 
> EVPD.

Some warnings:

	packet-scsi.c:1221: warning: missing braces around initializer
	packet-scsi.c:1221: warning: (near initialization for 
`scsi_senddiag_pf_val[0]')

That one shouldn't be an array.

	packet-scsi.c: In function `dissect_scsi_startstopunit()':
	packet-scsi.c:3145: warning: unused parameter `isreq'
	packet-scsi.c: In function `dissect_scsi_senddiag()':
	packet-scsi.c:3437: warning: unused parameter `iscdb'
	packet-scsi.c: In function `dissect_scsi_writebuffer':
	packet-scsi.c:3460: warning: unused parameter `iscdb'

Do the routines in question need to check the arguments in question?

"dissect_scsi_writebuffer()" and "dissect_scsi_senddiag ()" are always 
passed TRUE - which is also the case for "dissect_scsi_varlencdb()", 
but that checks its "iscdb" argument.

"dissect_scsi_startstopunit()" is passed TRUE in one call and the value 
of "isreq" in "dissect_scsi_payload()" in the other call - should it be 
checking its "isreq" argument?