Ethereal-dev: Re: [Ethereal-dev] Toolbar

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Wed, 15 Oct 2003 00:39:58 -0700
On Wed, Oct 15, 2003 at 09:26:03AM +0200, Ulf Lamping wrote:
> Regardless where to catch this information from the user, where else
> (if not in the preference file) we should save this info permanently?

That's where it'd be saved - I should've made it clear that in "do you
even need a preference?" "preference" referred to an item in the Edit >
Preferences dialog box, not to an item in a preferences file.

> With Mozilla, you would enable/disable a toolbar (they have two of it)
> by View->Show/Hide->Navigation Toolbar.

As per my recent mail, the enabling/disabling of the toolbar probably
belongs under a "View" menu - that's not unique to Mozilla.

> I think we could use one preference setting for it all and put the
> "none" setting into this, too.  So you will have four options:
> none,icons,text,both

A problem with that scheme is that you can't make the toolbar go away
without having Ethereal forget how the toolbar was displayed.  I'd have
separate show/hide toolbar options (accessible from a toggling item in a
"View" menu) and icons/text/both options.

> I'm using the stock items from GTK2 (where appropriate), but as they
> have a different file format (when I remember this correctly .png),
> which cannot be understood by GTK1, I converted this to the xpm format
> using the Gimp.  The xpm format can be understood from both GTK 1 and 2. 

Perhaps the code should just use "gtk_toolbar_insert_stock()" and the
appropriate stock item #define if GTK+ 2.x is used and the item is a
stock item, and use one of the other gtk_toolbar_insert calls otherwise. 
(Or perhaps there should be a fake "gtk_toolbar_insert_stock()" for GTK+
1.2[.x] that has the names and xpms wired into it, and the code should
use "gtk_toolbar_insert_stock()" in all cases where there's a GTK+ 2.x
stock item.)