Ethereal-dev: Re: [Ethereal-dev] 2 patches to packet-gtp.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxx>
Date: Mon, 11 Nov 2002 11:26:12 -0800
On Mon, Nov 11, 2002 at 09:50:06AM -0800, Guy Harris wrote:
> Instead, a new tvbuff should be constructed, with new data, and that
> data modified.

Or, instead, we should have the PPP dissector export its dissector
table, and have the GTP dissector go through that dissector table
itself, and not do any octet shuffling at all.  This also lets us get
rid of the option to control whether to do octet shuffling.

I've checked in a change to do that.

(Another possibility would be to have the GTP dissector have its own
dissector table, and have only the configuration protocols for PPP
register in that table, so bogus protocol ID values don't cause us to
dissect "configuration options" as IP packets or something such as
that.)