Ethereal-dev: Re: [Ethereal-dev] a small packet-icmpv6.c fix

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <guy@xxxxxxxxxx>
Date: Wed, 9 Jan 2002 11:13:47 -0800 (PST)
> Here's a patch to fix the lifetime in HMIPv6.

Checked in.

By the way:

>  	proto_tree_add_text(icmp6opt_tree, tvb,
>  	    offset + offsetof(struct nd_opt_map_info, nd_opt_map_lifetime),
> -	    4, "Lifetime: %d", pntohs(&map->nd_opt_map_lifetime));
> +	    4, "Lifetime: %d", pntohl(&map->nd_opt_map_lifetime));

Is the lifetime a signed, or unsigned, quantity?  Unsigned quantities
should be displayed with "%u", not "%d".