On Fri, Jan 04, 2002 at 01:10:04PM +0100, Jirka Novak wrote:
> Hi,
>
> I changed patch as we talk about.
> Now there is two submenus 'Match' and 'Prepare' (I think that Prepare is
> better than Insert in. If you don't, let me know). Both have this items:
> Selected, Not Selected, And Selected, Or Selected, And Not Selected, Or
> Not Selected
> 'Match' automaticly apply new expression, 'Prepare' doesn't. There is
> 'Apply' button besides 'Reset', it apply filter (faster than press enter
> if you drive with mouse).
> Both menus work in packet list and tree view. In packet list it gets
> expression for packet and it's column which is pointed (not selected!).
> In tree view it gets expression for selected row (as previously).
I tried out your patch. Firstly I had problems applying it because of
the way it was generated. There are no directory names in the diff commands:
diff -u -r1.9 column-utils.c
diff -u -r1.1 column_info.h
diff -u -r1.11 keys.h
diff -u -r1.222 main.c
diff -u -r1.25 main.h
diff -u -r1.58 menu.c
I like the idea; it's quite convenient.
However, I agree with the previous discussion that it's a bit confusing
to have both Match and Prepare menus. I think you could always not
apply the filter (especially since you have added the apply menu).
You can easily create a filter which will filter out all or most of your
packets. That makes it harder to add aditional filter cases, especially
when using OR to join expressions.
Maybe the filter entry box could be in a different colour if the
filter has been changed since it was last applied.
Also I noticed a bug. If you right click on the protocol
column, and apply any filter, you get an empty dialog box.
If you pick prepare instead, nothing is added to the filter
expression.
regards
Hamish
--
Hamish Moffatt VK3SB <hamish@xxxxxxxxxx> <hamish@xxxxxxxxxxxx>