["Ronnie Sahlberg" <rsahlber@xxxxxxxxxxxxxx>]

Hi Tim,

In your patch,
Why put FID as a hidden variable? If it is a FDI, then display it as a FID

So, something like this instead

guint16 sw1;
sw1=tbe_get_letohs(tvb, offset);
proto_tree_add_item(... smb_hf_setupword1

If sw1==0x26 then
    proto_tree_add_item(... smb_hf_fid 
else
    proto_tree_add_item(... smb_hf_setupword2



----- Original Message ----- 
From: "Tim Potter" <tpot@xxxxxxxxx>
To: <ethereal-dev@xxxxxxxxxxxx>
Sent: Sunday, November 18, 2001 7:59 AM
Subject: [Ethereal-dev] [PATCH] fid tracking


> Hi everyone.  Here is a small patch which starts to add fid tracking
> for msrpc calls.  Also, display the returned fid in the info
> column of the ntcreate&x reply.
> 
> I would like to be able to type "smb.fid == 0x4000" into the filter
> field and have all operations on that fid come up.  At the moment,
> it pops up with the ntcreate&x response, the dcerpc bind and msrpc
> requests, and the read&x requests for large dcerpc packets.  What I
> would like is the responses to be picked out as well by adding a 
> hidden uint item for the fid from the request packet.
> 
> Should I add this to the smb_info_t, or the smb_saved_info_t, or
> perhaps start breaking things out into a separate structure of its own
> like smb_ntcreate_info_t?
> 
> 
> Tim.
>