Ethereal-dev: Re: [Ethereal-dev] [PATCH] fid tracking

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Tim Potter <tpot@xxxxxxxxx>
Date: Mon, 19 Nov 2001 09:58:07 +1100
On Sun, Nov 18, 2001 at 09:25:27AM +1100, Ronnie Sahlberg wrote:

> In your patch,
> Why put FID as a hidden variable? If it is a FDI, then display it as a FID
> 
> So, something like this instead
> 
> guint16 sw1;
> sw1=tbe_get_letohs(tvb, offset);
> proto_tree_add_item(... smb_hf_setupword1
> 
> If sw1==0x26 then
>     proto_tree_add_item(... smb_hf_fid 
> else
>     proto_tree_add_item(... smb_hf_setupword2

I think I just wanted to be clever and use the proto_tree_add_*_hidden
functions.  (-:


Tim.