Wireshark-dev: [Wireshark-dev] Re: Reusing certain enums and rrc_sub_types from packet-gsmtap.c

From: Pascal Quantin <pascal@xxxxxxxxxxxxx>
Date: Wed, 4 Feb 2026 17:21:32 +0100
Hi Tamas,

4 févr. 2026 05:18:32 Tamás Regős <regost@xxxxxxxxx>:

> Hi Dev Team,
>
> Would it be ok to allow reusing certain enums and the rrc_sub_types from packet-gsmtap.c?

What we usually do in this situation is to put the enum in the header file and the array in the source file with an extern in the header file.

>
> What I mean is to move a complete enum structure from packet-gsmtap.c to packet-gsmtap.h and also define a value_string array in the header file.
>
> The related code is
>
> enum {
> GSMTAP_RRC_SUB_DL_DCCH_Message = 0,
> ...
> }
>
> and
> const value_string rrc_sub_types[]
>
> For now I had to completely duplicate these in the new code (packet-qcdiag) I've been working on.
>
> Thank you.
>
> Regards,
> Tamas

Best regards,
Pascal.