Sorry for the noise.
This issue seems to be fixed in libpcap in commit e50355893cd073c0
("socketcan: *really* fix CAN FD support.")
- canhdr->fd_flags &=
~(CANFD_FDF|CANFD_ESI|CANFD_BRS);
+ canhdr->fd_flags &=
(CANFD_FDF|CANFD_ESI|CANFD_BRS);
:-)
Thanks!
On 2024-02-11 22:48, Oliver Hartkopp wrote:
Another small issue:
On 2024-02-09 23:56, Guy Harris wrote:
and the Wireshark main and 4.2 branches include changes to
treat CAN frames without the CANXL_XLF flag or the CANFD_FDF flag
as FD frames if they're exactly 72 bytes long, to work around the
(fixed in the main and 1.10 branches) libpcap bug where CANFD_FDF is
unintentionally cleared;
Is it possible that the work around for the libpcap bug (set the
CANFD_FDF flag for non-XL frames with a length of 72 bytes) clears the
other bits in the CAN FD flags field?
The CANFD_BRS and CANFD_ESI bits are not visible anymore.
CANFD_FDF is only set in the CAN FD frames in recent kernels. In older
kernels only the PDU length of 72 is the indicator. But BRS/ESI were
always supported.
Best regards,
Oliver