Wireshark-dev: Re: [Wireshark-dev] SocketCAN Support is broken in latest Wireshark-v4.3.0rc0-14

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxx>
Date: Sun, 11 Feb 2024 14:16:39 -0800
On Feb 11, 2024, at 1:53 PM, Oliver Hartkopp <socketcan@xxxxxxxxxxxx> wrote:

> This issue seems to be fixed in libpcap in commit e50355893cd073c0 ("socketcan: *really* fix CAN FD support.")
> 
> 
> -                               canhdr->fd_flags &= ~(CANFD_FDF|CANFD_ESI|CANFD_BRS);
> +                               canhdr->fd_flags &= (CANFD_FDF|CANFD_ESI|CANFD_BRS);

Yes, *that* was the underlying reason why FD frames weren't being recognized as such; my trained-by-C-for-about-45-years brain sometimes automatically sticks a ~ after an &=, given that A &= ~B is the "clear the B bits" C idiom, so that ~ was there where it didn't belong. e50355893cd073c0 fixed that.