Wireshark-dev: Re: [Wireshark-dev] Faster packet list scrolling

From: Roland Knall <rknall@xxxxxxxxx>
Date: Thu, 28 Jul 2022 21:40:38 +0200
Okay, I have to rephrase that a little bit. It is not so much breaking but just not really something that has been done often. The issue here is discovery of new shortcuts. You rightly mention the option to put it in the help menu, but I think this is not enough.

Anyway, the option could be a good addition, I still don't really think it would be used by many people and therefore it makes it hard to support in the future. The scrollbars are a delicate thing in the code, which is why I am a little bit weary of changing their behavior. Btw, Brandon, the scrollbars would be the thing you have to change, not the list itself, as those handle the scrolling speed.

Roland

Am Do., 28. Juli 2022 um 21:30 Uhr schrieb Maynard, Christopher <Christopher.Maynard@xxxxxxx>:
Does it break UI guidelines?  I'm not claiming that it doesn't, but would you mind linking to such guidelines because nothing is jumping out at me at either https://developer.apple.com/design/human-interface-guidelines/inputs/keyboards/ or https://docs.microsoft.com/en-us/previous-versions/windows/desktop/dnacc/guidelines-for-keyboard-user-interface-design#creating-shortcut-keys-and-access-keys.

- Chris

From: Roland Knall <rknall@xxxxxxxxx>
Sent: Thursday, July 28, 2022 2:33 PM
To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Cc: Maynard, Christopher <Christopher.Maynard@xxxxxxx>
Subject: Re: [Wireshark-dev] Faster packet list scrolling

Well, that is a workaround solution, which I would accept if nothing else works, but still it breaks the UI guidelines of every major plattform

Am Do., 28. Juli 2022 um 17:55 Uhr schrieb Maynard, Christopher via Wireshark-dev <mailto:wireshark-dev@xxxxxxxxxxxxx>:
Must there be a menu-entry, after all, all* keyboard shortcuts are documented in "Help -> About Wireshark -> Keyboard Shortcuts".
- Chris
*except for Ctrl+Alt+C (Add New Comment) ... see https://gitlab.com/wireshark/wireshark/-/issues/18228


From: Wireshark-dev <mailto:wireshark-dev-bounces@xxxxxxxxxxxxx> On Behalf Of Roland Knall
Sent: Thursday, July 28, 2022 3:31 AM
To: Developer support list for Wireshark <mailto:wireshark-dev@xxxxxxxxxxxxx>
Subject: Re: [Wireshark-dev] Faster packet list scrolling

Yes, Qt implemented this feature but at the same time they demonstrate to great effect the lack in usefulness for it. Every hidden key needs to be demonstrated or shown, or it has to be something that users are used for their platforms. CTRL-C/CTRL-V comes to mind for the latter.

That is why every shortcut should have a corresponding menu-entry. So users can find and learn those shortcuts. But for the proposed solution I am kind of not seeing where we can put that entry. And because of that, only users who knew off the functionality while it was initially demonstrated will use it, the majority won’t. And that is my issue with implementing it.

If you want to do it anyway, please do, I’ll happily review it and help you get it implemented.

Roland


Am 28.07.2022 um 08:33 schrieb Brandon Foong <mailto:mailto:brandonfoongyankai@xxxxxxxxx>:

Hi Roland,

Thanks for the feedback. Another possibility I just thought of is to bind Alt + PgUp/PgDown to move the view up/down by 10 pages. What do you think about this?

On a side note, it seems like the idea of using a hotkey for faster scrolling has already been implemented by Qt, where (Ctrl/Shift) + scroll will effectively perform PgUp/PgDown.

Regards,
Brandon

On Fri, Jul 22, 2022, 10:30 Brandon Foong <mailto:mailto:brandonfoongyankai@xxxxxxxxx> wrote:
Hi,

I recently opened an issue on GitLab regarding increasing the scroll rate for larger captures (https://gitlab.com/wireshark/wireshark/-/issues/18213). I was considering between a few alternative implementations, and would like to get your opinion on this. They are:

1. Adding a hotkey that when pressed, increases the scroll speed by a multiplier
2. Adding a new field to the config that allows one to specify a constant multiplier on the scroll speed
3. Making it such that the scrolling speed automatically increases when it detects continuous scrolling (not sure how feasible this one is)

Thanks in advance!

Regards,
Brandon Foong











CONFIDENTIALITY NOTICE: This message is the property of International Game Technology PLC and/or its subsidiaries and may contain proprietary, confidential or trade secret information. This message is intended solely for the use of the addressee. If you are not the intended recipient and have received this message in error, please delete this message from your system. Any unauthorized reading, distribution, copying, or other use of this message or its attachments is strictly prohibited.