Wireshark-dev: Re: [Wireshark-dev] QT translation: lock keyboard shortcut terms?

From: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Date: Mon, 4 Apr 2016 19:34:16 +0200
Hi Uli,


On Fri, Apr 1, 2016 at 8:27 PM, Uli Heilmeier <zeugs@xxxxxxxxxxxx> wrote:
Hi list,

At the moment the translation source files ui/qt/wireshark_xx.ts contains
all the keyboard shortcuts (e.g. like 'Ctrl+Home'). Therefore these terms
are also listed in Transifex.

However these terms are translated "automatically" with the qt_xx.qm
files. Doing a manually translation breaks the display of the shortcuts in
the UI (s.
https://www.wireshark.org/lists/wireshark-dev/201511/msg00101.html).

I did the mistake to translate the terms some month ago and another
member of the German Transifex team has done the same mistake this week.
I have the member to contact you before...
 

How can we prevent this?
* Remove keyboard shortcuts from the wireshark_xx.ts file (if feasible)
After a check, yes, it is possible to remove (via Qt Design for example "Close"
diff --git a/ui/qt/main_window.ui b/ui/qt/main_window.ui
index 021d788..881f6c7 100644
--- a/ui/qt/main_window.ui
+++ b/ui/qt/main_window.ui
@@ -817,7 +817,7 @@
     <string>Close this capture file</string>
    </property>
    <property name="shortcut">
-    <string>Ctrl+W</string>
+    <string notr="true">Ctrl+W</string>
    </property>
    <property name="iconVisibleInMenu">
     <bool>false</bool>

and after it is remove from ts file

* Lock the terms (non writeable) in Transifex (if feasible)
Sorry, it is no possible (only can add translator note : "DON'T TRANSLATE !")
* Establish a review process (like Gerrit) for translation files

It is possible to have "Reviewer" on Transifex, if you are interresed and can add you to reviewer group for check german translation
 
 
At the moment the translation is synced automatically (also for master-20).

Any opinions? 

Cheers
Uli
Regards,
Alexis
 
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe