On Wed, Feb 5, 2014 at 9:33 AM, Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> wrote:
> I saw some emails about the -commits emails still being a work in progress
> but that was a while ago. Is that still the case?
>
> I just thought I'd mention that I'm not a fan of the current mails where we
> only get the one line summary of the change: I'd (much) prefer to have the
> full text of the commit message.
And as of this morning (or perhaps slightly earlier) I've stopped
receiving them at all...?
You can ask Gerrit (in your user preferences) to send you notification
whenever a patchset is submitted; I'm not sure what those emails look
like but they might be more useful.
> For example I'd rather see this:
>
>> Fix Bug 9725 'Lua: ProtoField.new() is buggy'
>>
>> Using ProtoField.new() is dicey. Many of the optional arguments don't
>> properly check the lua stack - they call lua_isnil() for their index number,
>> instead of lua_gettop() to see the stack size. lua_isnil() may return false
>> in such cases.
>
>
> Than:
>
>> from c391d74 Fix wslua docs script to handle module names with
>> digits, like Int64/UInt64
>> adds 2466a7c Fix Bug 9725 'Lua: ProtoField.new() is buggy'
>
>
> I can learn a lot more (and better follow what others are
> discovering/working on) with the details in the former example.
> ___________________________________________________________________________
> Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives: http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe