Maybe it would be better to open an enhancement bug request for this and continue the discussion, if needed, within the bug report?
- Chris
________________________________________
From: wireshark-dev-bounces@xxxxxxxxxxxxx [wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Joerg Mayer [jmayer@xxxxxxxxx]
Sent: Friday, April 23, 2010 5:32 PM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] RFC: sorted value_string + bsearch
On Fri, Apr 23, 2010 at 10:04:30AM -0400, Maynard, Chris wrote:
> So, with that in mind ... is there a way, or could there be a way, to verify that certain value string arrays are properly sorted and remain so, perhaps during compilation or at least via a tools/checkXYZ.pl script?
I don't like that approach. If the array is sorted incorrectly, please
don't bail out but print a message about the fact and restart but with
an extra sorting pass in the beginning. It's bad enough we bail out in
many places in the intialization with non-descriptive asserts in proto.c,
so please don't add another one.
Ciao
Joerg
--
Joerg Mayer <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
CONFIDENTIALITY NOTICE: The contents of this email are confidential
and for the exclusive use of the intended recipient. If you receive this
email in error, please delete it from your system immediately and
notify us either by email, telephone or fax. You should not copy,
forward, or otherwise disclose the content of the email.