Maybe it would be better to open a new bug for this so it's not forgotten about? And maybe the Pidl Wiki page should be updated to indicate that patches should be submitted via bugzilla instead? Or not. I just know that the core developers don't always have the time to review and commit the patches right away so if it's filed with bugzilla, then it won't be lost or forgotten.
- Chris
________________________________________
From: wireshark-dev-bounces@xxxxxxxxxxxxx [wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Jeff Morriss [jeff.morriss.ws@xxxxxxxxx]
Sent: Saturday, April 24, 2010 3:07 PM
To: samba-technical@xxxxxxxxx
Cc: Developer support list for Wireshark
Subject: [Wireshark-dev] Pidl patch for ABSOLUTE_TIMEs
Hello,
The Wireshark Wiki page:
http://wiki.wireshark.org/Pidl
says to send patches against Pidl to this address.
Pidl generates some Wireshark dissector fields of type
FT_ABSOLUTE_TIME. Starting some time not too long ago, these fields
need a 'display' field other than BASE_NONE or BASE_DEC. The attached
patch fixes this, *assuming* that all the times are "local." Other
options include:
ABSOLUTE_TIME_UTC, /* UTC, with month and day */
ABSOLUTE_TIME_DOY_UTC /* UTC, with 1-origin day-of-year */
For now (to keep Wireshark running) I've modified the dcerpc-lsa
dissector manually; this is my attempt to push the patch upstream.
Regards,
-Jeff
CONFIDENTIALITY NOTICE: The contents of this email are confidential
and for the exclusive use of the intended recipient. If you receive this
email in error, please delete it from your system immediately and
notify us either by email, telephone or fax. You should not copy,
forward, or otherwise disclose the content of the email.