Wireshark-dev: Re: [Wireshark-dev] Dissector for Cisco ITP packet logging facility

From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Tue, 6 Feb 2007 20:18:42 +0100
On Tue, Feb 06, 2007 at 09:53:32AM +0800, Jeff Morriss wrote:
> > I have just on concern... The Cisco allows the user to set the syslog
> > facility and severity when starting the debug. The values you saw were
> > the default values. Therefore, checking for LOCAL0/DEBUG only might
> > cause problems if the user chooses to select non-default values.
> > However, like you said, most syslog packets will not contain MSUs, so
> > it is important that we don't waste CPU cycles. I think it is best we
> > leave this check in, until someone complains :-)
> 
> Hmm, well, it's not really saving that much CPU time, but I also suspect 
> that the vast majority of people will leave the default value there so 
> hopefully it won't matter.  As you said, if it does, we can always 
> change it later.  (The only problem with that is if someone doesn't even 
> know the feature is there because it doesn't automatically show up: in 
> that case they won't know that they could complain and have it changed.)

How about adding two preference elements for it?

 ciao
    Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.