Wireshark-dev: Re: [Wireshark-dev] [Patch] epan/make-sminmpec.pl

From: Andrew Feren <acferen@xxxxxxxxx>
Date: Thu, 7 Sep 2006 10:27:06 -0700 (PDT)
--- LEGO <luis.ontanon@xxxxxxxxx> wrote:

> Committed revision 19172.
> 
> I modified so that calling it like
>    make-sminmpec.pl -gen
> is like calling it
>    make-sminmpec.pl -gen \
>          http://www.iana.org/assignments/enterprise-numbers \
>          sminmpec.c

If you try using this default I doubt very much you will get the results you
want.  Attached is a patch to your patch of my patch.  ;-)

changes:
changed -gen to -cp  since I think the name makes more sense

infile always defaults to http://www.iana.org/assignments/enterprise-numbers

with the -cp switch
outfile defaults to enterprise-numbers

without the -cp swith
outfile defaults to sminmpec.c

-Andrew

> Luis
> 
> On 9/7/06, Andrew Feren <acferen@xxxxxxxxx> wrote:
> > This adds some features to update enterprise-numbers from the web.  After
> I
> > submitted a large update for epan/enterprise-numbers yesterday I got to
> > thinking that there ought to be a way to automate keeping the file up to
> > date.
> >
> > As used in the Makefile currently
> >   make-sminmpec.pl <infile> <outfile.c>
> >
> > works exactly the same.  Additionally <infile> can be a URL to an infile
> in
> > the expected format.
> >
> > example :
> > make-sminmpec.pl http://www.iana.org/assignments/enterprise-numbers
> > sminmpec.c
> >
> > Using the new "-gen" switch will create a new <infile>
> >
> > example:
> > make-sminmpec.pl -gen \
> >     http://www.iana.org/assignments/enterprise-numbers \
> >     enterprise-numbers
> >
> > if you use a local file for infile the -gen switch is the moral
> equivalent of
> > just copying the file.  (maybe -cp would be a better switch name)
> >
> > I didn't update any Makefiles since I think in general people don't
> need/want
> > to update off the web for every build.  Perhaps using this to update
> > enterprise-numbers could be run with make-manuf.   (Is manuf run
> > periodically?  If so when?  Just curious.)
> >
> > -Andrew
> >
> > -Andrew Feren
> >  acferen@xxxxxxxxx
> >
> > _______________________________________________
> > Wireshark-dev mailing list
> > Wireshark-dev@xxxxxxxxxxxxx
> > http://www.wireshark.org/mailman/listinfo/wireshark-dev
> >
> >
> >
> >
> 
> 
> -- 
> This information is top security. When you have read it, destroy yourself.
> -- Marshall McLuhan
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-dev
> 

-Andrew Feren
 acferen@xxxxxxxxx

Attachment: my_patch.gz
Description: 3270623545-my_patch.gz