Wireshark-commits: [Wireshark-commits] master-3.2 c534b0a: epan DTD parser: don't leak the full pat

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 02 May 2020 22:19:18 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c534b0adc7b9bd3107c66fcb6bb949cdec5b22d0
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

c534b0a by Guy Harris (guy@xxxxxxxxxxxx):

    epan DTD parser: don't leak the full path string on error.
    
    While we're at it, fix a return - the return value is a pointer, with
    NULL meaning error, not a Boolean, with FALSE meaning error, so return
    NULL, not FALSE.
    
    Change-Id: Ie77fe2c6173293a2a202ad29a6c5033e2a401aa7
    Ping-Bug: 16335
    Reviewed-on: https://code.wireshark.org/review/37033
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    (cherry picked from commit 7478d1fc3bd213e3aa5f1193723924ddaa080f62)
    Reviewed-on: https://code.wireshark.org/review/37035
    

Actions performed:

    from  0df4df5   Fix memory leak in export_object.c
     add  c534b0a   epan DTD parser: don't leak the full path string on error.


Summary of changes:
 epan/dtd_preparse.l | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)