Wireshark-commits: [Wireshark-commits] master 3618aa2: epan DTD parser: don't leak the full path st

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 02 May 2020 22:19:06 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3618aa2cc68eeb7b9d0ab52a388f74eee382d09d
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3618aa2 by Guy Harris (guy@xxxxxxxxxxxx):

    epan DTD parser: don't leak the full path string on error.
    
    While we're at it, fix a return - the return value is a pointer, with
    NULL meaning error, not a Boolean, with FALSE meaning error, so return
    NULL, not FALSE.
    
    Change-Id: Ie77fe2c6173293a2a202ad29a6c5033e2a401aa7
    Ping-Bug: 16335
    Reviewed-on: https://code.wireshark.org/review/37033
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  4067652   Fix memory leak in export_object.c
     add  3618aa2   epan DTD parser: don't leak the full path string on error.


Summary of changes:
 epan/dtd_preparse.l | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)