Wireshark-commits: [Wireshark-commits] master 9f03cde: Add a routine to get the representation of a

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 25 Apr 2020 06:28:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9f03cde5a55dd2f3ffba23935c1ccb8b02f0ffe6
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9f03cde by Guy Harris (guy@xxxxxxxxxxxx):

    Add a routine to get the representation of a protocol tree item and use it.
    
    Add proto_item_get_display_repr(), which returns a string, allocated
    with a specified wmem scope, containing the display representation of
    the value of a proto_item.
    
    Use it in the LLDP dissector, to append that string to the parent
    protocol tree item; use packet scope, so it doesn't hang around forever
    (the previous code used the NULL scope, meaning explicit freeing was
    required, but it wasn't explicitly freeing the value, so it was
    leaking).
    
    Change-Id: I146380118833b1daef9dea8bd9463001e5b9325f
    Reviewed-on: https://code.wireshark.org/review/36931
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  9750d00   Introduce tfs_get_string helper
     add  9f03cde   Add a routine to get the representation of a protocol tree item and use it.


Summary of changes:
 debian/libwireshark0.symbols  |  1 +
 epan/dissectors/packet-lldp.c | 71 +++++++++++--------------------------------
 epan/proto.c                  | 10 ++++++
 epan/proto.h                  |  8 ++++-
 4 files changed, 35 insertions(+), 55 deletions(-)