Wireshark-commits: [Wireshark-commits] master 9750d00: Introduce tfs_get_string helper

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 25 Apr 2020 04:39:54 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9750d00ff10bc344a2b1dcc69ee34d09a7ce76d0
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9750d00 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Introduce tfs_get_string helper
    
    true_false_strings have no helper function to properly retrieve the
    string representing the true or false value, much like unit_strings,
    even though this is not uncommon in dissectors.
    This change introduces the helper function and modifies the dissectors,
    so that they use this helper i.s.o. their own expressions.
    
    Change-Id: I477ed2d90a9a529fc5dcfef7e3ea42ec180d27ae
    Reviewed-on: https://code.wireshark.org/review/36920
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c9295f1   isakmp: clean up EMERGENCY_CALL_NUMBER dissection.
     add  9750d00   Introduce tfs_get_string helper


Summary of changes:
 debian/libwireshark0.symbols           |  1 +
 epan/dissectors/packet-ansi_a.c        |  2 +-
 epan/dissectors/packet-ber.c           | 22 +++++++++++-----------
 epan/dissectors/packet-bgp.c           | 18 +++++++++---------
 epan/dissectors/packet-btle.c          |  6 +++---
 epan/dissectors/packet-dmp.c           | 30 +++++++++++-------------------
 epan/dissectors/packet-f5ethtrailer.c  |  8 ++++----
 epan/dissectors/packet-ieee802154.c    |  2 +-
 epan/dissectors/packet-ipmi-se.c       |  2 +-
 epan/dissectors/packet-isakmp.c        | 10 +++++-----
 epan/dissectors/packet-iso14443.c      | 22 ++++++----------------
 epan/dissectors/packet-netlink-route.c |  2 +-
 epan/dissectors/packet-pfcp.c          |  6 +++---
 epan/dissectors/packet-wassp.c         |  4 +---
 epan/proto.c                           | 12 ++++--------
 epan/tfs.c                             | 18 ++++++++++++++++++
 epan/tfs.h                             | 20 ++++++++++++++++++--
 rawshark.c                             |  4 ++--
 18 files changed, 100 insertions(+), 89 deletions(-)